Skip to content

Pictogram search #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Pictogram search #47

wants to merge 2 commits into from

Conversation

AliLee0923
Copy link
Contributor

This PR is for issue 46. The original logic is getting pictograms using search endpooint if the best search endpoint returns null.
Here are what I did:

  • Get synonym if the search endpoint returns null
  • Try to get pictograms with synonym using search endpoint
  • Repeat this 5 times. From second time, it tries to get synonym of previous synonym.

close #46

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use Synonyms when ARASAAC returns 404
1 participant
@AliLee0923